Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Zip issue with infinite streams. #545

Merged
merged 2 commits into from
Dec 3, 2013

Conversation

akarnokd
Copy link
Member

Issue #539

@cloudbees-pull-request-builder

RxJava-pull-requests #477 SUCCESS
This pull request looks good

@headinthebox
Copy link
Contributor

Do we have similar tests for the error cases as well?

@akarnokd
Copy link
Member Author

akarnokd commented Dec 1, 2013

There are two test methods done previously: OperationZipTest.testOnErrorTermination and OperationZipTest.testAggregatorError. I'll add some more tests.

@cloudbees-pull-request-builder

RxJava-pull-requests #480 SUCCESS
This pull request looks good

@headinthebox
Copy link
Contributor

Thanks!

benjchristensen added a commit that referenced this pull request Dec 3, 2013
Fixed Zip issue with infinite streams.
@benjchristensen benjchristensen merged commit cee14e1 into ReactiveX:master Dec 3, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
Fixed Zip issue with infinite streams.
@akarnokd akarnokd deleted the ZipInfiniteFix branch January 13, 2014 10:03
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants